Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facet search support #592

Merged
merged 11 commits into from
Jan 8, 2025
Merged

Conversation

danFbach
Copy link
Contributor

@danFbach danFbach commented Dec 4, 2024

Pull Request

Related issue

Fixes #461

What does this PR do?

  • implements facet search

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Few notes:

  • Implemented the FacetSearchAsync method with a facetName parameter seperate from a FacetSearchQuery object parameter, similar to how SearchAsync separates out the query parameter from the SearchQuery object, since these parameters are required.
  • Not sure how we want to handle an empty or null facetName? This may change tests requirements. See commented out tests
  • Test FacetSearchWithFilterFacetIsNull is "wrong." Perhaps this is just how meilisearch works, but filtering by genre IS NULL returns nothing, but 2 entries in the IndexForFaceting-SearchTests have a null genre. Would like some feedback here
  • Any additional tests?

@curquiza curquiza changed the title Facet search 461 Add Facet search support Jan 6, 2025
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

thank you a lot @danFbach

@curquiza curquiza added the enhancement New feature or request label Jan 8, 2025
Copy link
Contributor

meili-bors bot commented Jan 8, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 1dadb40 into meilisearch:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Search in facet values facetSearch
3 participants