Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new search param showRankingScoreDetails #528

Conversation

Tommy-42
Copy link
Contributor

@Tommy-42 Tommy-42 commented May 4, 2024

Pull Request

Related issue

Fixes #518

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Tommy-42 Tommy-42 force-pushed the feature/add_new_search_param_show_ranking_score_details branch from 75b5490 to 66755b4 Compare May 4, 2024 03:47
@curquiza curquiza added the enhancement New feature or request label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (442b48e) to head (66755b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   83.50%   83.52%   +0.02%     
==========================================
  Files          10       10              
  Lines        1582     1584       +2     
==========================================
+ Hits         1321     1323       +2     
  Misses        147      147              
  Partials      114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Tommy-42 🙏

bors merge

Copy link
Contributor

meili-bors bot commented May 6, 2024

@meili-bors meili-bors bot merged commit 805c05a into meilisearch:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v.1.7] Able to use showRankingScoreDetails parameter at search
2 participants