Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to the next Meilisearch release (v1.9.0) #535

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

meili-bot
Copy link
Contributor

Related to this issue: meilisearch/integration-guides#301

This PR:

  • gathers the changes related to the next Meilisearch release (v1.9.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of Meilisearch.
  • might eventually contain test failures until the Meilisearch v1.9.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.9.0) is out.

This PR is auto-generated for the pre-release week purpose.

@curquiza
Copy link
Member

The purpose here is to update the tests to make it work with v1.9

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (0131c58) to head (12d4678).

Current head 12d4678 differs from pull request most recent head 6aa0623

Please upload reports for the commit 6aa0623 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          10       10           
  Lines        1600     1600           
=======================================
  Hits         1386     1386           
  Misses        116      116           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza force-pushed the bump-meilisearch-v1.9.0 branch 4 times, most recently from 5678e21 to e795f60 Compare June 20, 2024 16:58
@curquiza curquiza added enhancement New feature or request and removed maintenance Anything related to maintenance (CI, tests, refactoring...) labels Jun 20, 2024
@curquiza
Copy link
Member

I added the retrieveVector parameter to ease the test part

@curquiza curquiza added breaking-change The related changes are breaking for the users and removed enhancement New feature or request labels Jun 24, 2024
@curquiza
Copy link
Member

curquiza commented Jun 24, 2024

Putting breaking changes because the hybrid changes on Meilisearch are breaking, so I want to inform the users, even if it's not breaking on the go SDK side

@curquiza curquiza marked this pull request as ready for review July 1, 2024 11:40
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Copy link
Contributor

meili-bors bot commented Jul 1, 2024

@meili-bors meili-bors bot merged commit 688ce36 into main Jul 1, 2024
4 of 6 checks passed
@meili-bors meili-bors bot deleted the bump-meilisearch-v1.9.0 branch July 1, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants