Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code samples for sub-setting methods #274

Merged
merged 11 commits into from
Feb 2, 2022

Conversation

irenejoeunpark
Copy link
Contributor

Issue #269
Added/updated code samples for sub-setting methods

Added reset samples and updated update samples for the following sub-setting methods.

  • Synonyms
  • Stop-words
  • Searchable attributes
  • Displayed attributes
  • Attributes for faceting
  • Distinct attribute

@curquiza curquiza changed the title Issue #269 - Add code samples for sub-setting methods Add code samples for sub-setting methods Nov 3, 2021
@curquiza curquiza linked an issue Nov 3, 2021 that may be closed by this pull request
@curquiza curquiza requested a review from alallema November 3, 2021 14:42
@curquiza
Copy link
Member

curquiza commented Nov 3, 2021

Thanks for your PR @irenejoeunpark
@alallema is on holiday right now and will review your PR once she comes back :)

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Nov 3, 2021
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @irenejoeunpark!
I propose some fixes and also if you want to update the update_ranking_rules_1, here is the code:

  client.index("movies").updateRankingRuleSettings(new String[]
  {
    "words",
    "typo",
    "proximity",
    "attribute",
    "sort",
    "exactness",
    "release_date:asc",
    "rank:desc"
  });

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved
@alallema
Copy link
Contributor

I forgot to say that all the get sub-settings samples should be updated too. They have all been renamed with Settings at the end.
For example:

client.index("movies").getRankingRules();

became:

client.index("movies").getRankingRuleSettings();

@alallema
Copy link
Contributor

alallema commented Feb 2, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 2, 2022

Build succeeded:

@bors bors bot merged commit 316a799 into meilisearch:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update .code-samples.meilisearch.yaml with the new sub-settings methods
3 participants