Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom csv delimiter #726

Merged
merged 9 commits into from
May 15, 2024
Merged

Conversation

jennweir
Copy link
Contributor

@jennweir jennweir commented Apr 22, 2024

Pull Request

Related issue

Addresses #590

What does this PR do?

  • Includes csvDelimiter parameter in the addDocuments method
  • Includes csvDelimiter parameter in the updateDocuments method

Issue #590 has two subtasks as listed below:

  • Add the new argument to the csv document handler methods
  • Add tests
  • Tests are not included because there are some clarifications that we require to verify if the issue is already partially/completely implemented. After adding the csvDelimiter to each method, we researched adding a custom csv delimiter in Java and found no built-in support. Would this be best completed by utilizing an external library like OpenCSV?
  • This PR addresses the function parameter additions to support a custom csvDelimiter if necessary but does not adequately test the functionality of these additions.
  • It is unclear from the issue if this is already implemented, this would address the first subtask for Configure the CSV delimiter when updating documents #590 if the issue has not been implemented yet.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @jennweir

ok for the tests

bors merge

Copy link
Contributor

meili-bors bot commented May 15, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit e6a7c16 into meilisearch:main May 15, 2024
3 checks passed
@curquiza curquiza added the enhancement New feature or request label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants