-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export meilisearch
package, and expose created MeiliSearch
instance
#1271
Re-export meilisearch
package, and expose created MeiliSearch
instance
#1271
Conversation
…already in tsconfig.json which it extends, marked node module imports as explicit ("node:(...)"), added types to some scripts for IDE hints.
🦋 Changeset detectedLatest commit: ad3c63b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -2,7 +2,6 @@ | |||
"extends": "./tsconfig.json", | |||
"compilerOptions": { | |||
"suppressImplicitAnyIndexErrors": true, | |||
"resolveJsonModule": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 can you explain that 😅 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already set as true
in the tsconfig.json
this config file extends:
"resolveJsonModule": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems pretty good to me!
bors merge |
Build succeeded:
|
Pull Request
Related issue
Fixes #1260
What does this PR do?
MeiliSearch
instance"meilisearch"
packageThese improvements make it so that no separate
"meilisearch"
packagehas to be installed in order to use its exports directly. This
way a single
MeiliSearch
instance can be re-used, and we can potentiallysave on bundle size by avoiding a separate different version installation of
"meilisearch"
.