Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instant-meilisearch): add ranking score threshold #1318

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

Strift
Copy link
Collaborator

@Strift Strift commented Aug 14, 2024

Related issue

Fixes #1315

What does this PR do?

features:

  • add rankingScoreThreshold to the search parameters
  • update README.md to list the new search parameter
  • sort search parameters alphabetically (in the readme & the code)

maintenance:

  • add .nvmrc to pin node version
  • pin package manager in package.json

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: f6649aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@meilisearch/instant-meilisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Strift Strift self-assigned this Aug 14, 2024
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunoocasali
Copy link
Member

bors merge

@Strift Strift merged commit 72a0346 into main Aug 14, 2024
7 checks passed
@Strift Strift deleted the feat/add-ranking-score-threshold branch August 14, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for rankingScoreThreshold
2 participants