Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlighting tests #1341

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Strift
Copy link
Collaborator

@Strift Strift commented Dec 6, 2024

Pull Request

Related issue

Fixes #1340

What does this PR do?

  • Update tests on results highlights to follow new formatting

Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 784df79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Strift Strift changed the base branch from main to bump-meilisearch-v0.12.0 December 6, 2024 07:24
@Strift
Copy link
Collaborator Author

Strift commented Dec 6, 2024

Hi @curquiza @mdubus, it appears the Tests workflow is triggered instead of the Pre-Release Tests one.

As a result, tests are not run against Meilisearch's last version (v1.12.0-rc.3), and they are failing.

Do you know why this is happening?
Maybe it's because I initially targeted main instead of the bump-meilisearch-v0.12.0 branch?

@curquiza
Copy link
Member

curquiza commented Dec 9, 2024

@Strift
it's because you create the PR and THEN you changed the base branch (we can see it in the historic). GitHub does not trigger again the automation.

So, I will merge this branch, and if this PR still have the Pre-release tests failing, you will open another one 😊

@curquiza curquiza merged commit bc826bb into bump-meilisearch-v0.12.0 Dec 9, 2024
4 of 6 checks passed
@curquiza curquiza deleted the feat/update-highlighting-tests branch December 9, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.12.0] Adapt tests to new Meilisearch highlight behavior
2 participants