Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination tests + fix pagination #387

Merged
merged 11 commits into from
May 3, 2021
Merged

Add pagination tests + fix pagination #387

merged 11 commits into from
May 3, 2021

Conversation

bidoubiwa
Copy link
Contributor

No description provided.

@bidoubiwa bidoubiwa changed the base branch from main to tests_suites May 3, 2021 16:22
@bidoubiwa bidoubiwa requested review from alallema and curquiza May 3, 2021 16:28
@bidoubiwa bidoubiwa changed the title Add pagination tests Add pagination tests + fix pagination May 3, 2021
curquiza
curquiza reviewed May 3, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice display and the list of tests seems exhaustive :)

Why do you name the variables algolia... in your tests, like algoliaNumberPagesBehavior? I understand this is a list for our tests with the parameters and the expected return. No need to mention algolia, right?

src/transformers/__tests__/pagination.tests.ts Outdated Show resolved Hide resolved
src/transformers/__tests__/pagination.tests.ts Outdated Show resolved Hide resolved
src/transformers/__tests__/pagination.tests.ts Outdated Show resolved Hide resolved
src/transformers/__tests__/utils.ts Outdated Show resolved Hide resolved
bidoubiwa and others added 4 commits May 3, 2021 19:09
@bidoubiwa @curquiza
Update src/transformers/__tests__/utils.ts
225dbf9 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa @curquiza
Update src/transformers/__tests__/pagination.tests.ts
966a0d7 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa @curquiza
Update src/transformers/__tests__/pagination.tests.ts
640468b 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa @curquiza
Update src/transformers/__tests__/pagination.tests.ts
63c288a 
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
@bidoubiwa
Copy link
Contributor Author

Why do you name the variables algolia... in your tests, like algoliaNumberPagesBehavior? I understand this is a list for our tests with the parameters and the expected return. No need to mention algolia, right?

Okey! Since it was the behavior of Algolia I thought why not name it like that but I understand your point.

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 3, 2021

Build succeeded:

@bors bors bot merged commit 7ad63eb into tests_suites May 3, 2021
@bors bors bot deleted the add_pagination_tests branch May 3, 2021 18:27
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label May 24, 2021
@bidoubiwa bidoubiwa mentioned this pull request May 24, 2021
Merged
bors bot added a commit that referenced this pull request May 25, 2021
@bors @bidoubiwa
Merge #408
300b7bb 
408: Add snippet/highlight/pagination integration tests r=bidoubiwa a=bidoubiwa

see #389 

Unit tests have also been added see: 
#387


Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@alallema alallema Awaiting requested review from alallema

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidoubiwa @curquiza