Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration and unit tests on filters #393

Merged
merged 3 commits into from
May 10, 2021
Merged

Add integration and unit tests on filters #393

merged 3 commits into from
May 10, 2021

Conversation

bidoubiwa
Copy link
Contributor

No description provided.

@bidoubiwa bidoubiwa mentioned this pull request May 7, 2021
Closed
@bidoubiwa bidoubiwa requested review from alallema and curquiza May 7, 2021 08:36
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label May 7, 2021
bidoubiwa and others added 2 commits May 7, 2021 10:47
@bidoubiwa
Change react playground to function component
6f78a5c
@bors @bidoubiwa
Merge #395
6c479e0 
395: Change react playground to function component r=bidoubiwa a=bidoubiwa

We mixed two component styles. This PR make our playground code more consistent

Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
alallema
alallema approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

curquiza
curquiza approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 10, 2021

Build succeeded:

@bors bors bot merged commit 0c443eb into main May 10, 2021
@bors bors bot deleted the filter_tests branch May 10, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bidoubiwa @alallema @curquiza