Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facets tests #400

Merged
merged 4 commits into from
May 11, 2021
Merged

Facets tests #400

merged 4 commits into from
May 11, 2021

Conversation

bidoubiwa
Copy link
Contributor

No description provided.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label May 10, 2021
@bidoubiwa bidoubiwa requested review from curquiza and alallema May 10, 2021 16:20
@bidoubiwa bidoubiwa mentioned this pull request May 10, 2021
Closed
@bidoubiwa bidoubiwa requested a review from curquiza May 10, 2021 16:48
curquiza
curquiza reviewed May 11, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test with facet + a non-empty query?
Sorry if I missed it!

@bidoubiwa bidoubiwa requested a review from curquiza May 11, 2021 15:51
alallema
alallema approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM!

curquiza
curquiza approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented May 11, 2021

Build succeeded:

@bors bors bot merged commit 23cf7ae into main May 11, 2021
@bors bors bot deleted the facets_tests branch May 11, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bidoubiwa @alallema @curquiza