Cleaning in tests #727
Merged
Cleaning in tests #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
skip-changelog
brunoocasali
reviewed
Apr 4, 2022
…ts.ts Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
…ts.ts Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
brunoocasali
previously approved these changes
Apr 5, 2022
|
bors merge |
brunoocasali
reviewed
Aug 2, 2022
| defaultFacetDistribution: {}, | ||
| finitePagination: false, | ||
| const DEFAULT_CONTEXT = { | ||
| indexUid: 'test', |
There was a problem hiding this comment.
I think the same idea can be applied here, don't you think? https://github.com/meilisearch/meilisearch-ruby/pull/354/files#r934317471
There was a problem hiding this comment.
Do you think test is not a good index name? Also these are unit tests so they will not be done against meilisearch
| expect(key).toEqual('""""""') | ||
| }) | ||
| test('Test to format empty string', () => { | ||
| test('to format empty string', () => { |
meili-bors bot
added a commit
that referenced
this pull request
Aug 4, 2022
819: Remove redundant words in tests description r=bidoubiwa a=bidoubiwa as per this comment #727 (comment) Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on these comments the tests are made more readable and consistent:
Testin front of test name