-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination system on resources for v0.28.0 #1269
Merged
bidoubiwa
merged 11 commits into
bump-meilisearch-v0.28.0
from
pagination_system_v0.28.0
Jun 27, 2022
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c489f77
Add pagination on documents
bidoubiwa 8084e9b
Add pagination on documents
bidoubiwa 1c2a70e
Add pagination on indexes and keys
bidoubiwa bb03536
Merge
bidoubiwa 84b03e0
Improve typing
bidoubiwa 4feb2f3
Add pagination on tasks
bidoubiwa 5f9f741
Add tests on pagination
bidoubiwa 2c7ad8c
Update task types
bidoubiwa d4a5523
Add default parameters in JS docs
bidoubiwa 7f71ffa
Update TaskParam to TasksQuery
bidoubiwa 8dcf016
Fix typing of getTask in JsDocs
bidoubiwa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a kind of https://en.wikipedia.org/wiki/Hungarian_notation not sure if this is the best choice, why not just
Index
are you using it somewhere else??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Index is the instance of an Index class. While IndexObject is the object representation of that same information.
Index(...)
vs{ ... }
see here: