Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search code-sample for v0.28.0 #1288

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Update search code-sample for v0.28.0 #1288

merged 1 commit into from
Jul 6, 2022

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jul 6, 2022 •
edited
Loading

As per this issue

  • Update search_parameter_guide_matches_1 PR
    • Rename code sample to search_parameter_guide_show_matches_position_1
    • Rename matches parameter to showMatchesPosition
  • Update faceted_search_facets_distribution_1 PR
    • Rename code sample to faceted_search_facets_1
    • Rename facetsDistribution parameter to facets

@bidoubiwa bidoubiwa requested review from brunoocasali and mdubus July 6, 2022 11:09
@bidoubiwa bidoubiwa mentioned this pull request Jul 6, 2022
Merged
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jul 6, 2022
@bidoubiwa bidoubiwa merged commit 407f800 into meili-bot/code-samples-v0-28 Jul 6, 2022
@bidoubiwa bidoubiwa deleted the update_search_code_samples_v0.28.0 branch July 6, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

@mdubus mdubus Awaiting requested review from mdubus

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidoubiwa @brunoocasali