Update settings code-sample for v0.28.0 #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
reviewed
Jul 6, 2022
| client.index('books').updateSettings({ faceting: { maxValuesPerFacet: 2 }}) | ||
| reset_faceting_settings_1: |- | ||
| settings_guide_faceting_1: |- | ||
| client.index('books').updateSettings({ faceting: { maxValuesPerFacet: 5 }}) |
There was a problem hiding this comment.
This method will be replaced when we implement those special methods correct?
There was a problem hiding this comment.
Yes ! Its per our discussion we had privately that i ve added them
brunoocasali
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this issue
Addget_pagination_settings_1PRbooksindexupdate_pagination_settings_1PRbooksindex"maxTotalHits": 100Addreset_pagination_settings_1PRbooksindexupdate_settings_1PR, PR"pagination": {"maxTotalHits": 5000}"faceting": { "maxValuesPerFacet": 200}Addget_faceting_settings_1PRbooksindexupdate_faceting_settings_1PRbooksindex"maxValuesPerFacet": 2Addreset_faceting_settings_1PRbooksindexsettings_guide_faceting_1PRmoviesindex"maxValuesPerFacet": 5settings_guide_pagination_1PRmoviesindex"maxTotalHits": 50