Add support to the pagination setting customization at the index level #1339

vishalsodani · 2022-10-01T19:21:14Z

Pull Request

What does this PR do?

Fixes #1298

PR checklist

Please check if your PR fulfills the following requirements:

Does this PR fix an existing issue?
Have you read the contributing guidelines?
Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa · 2022-10-02T07:23:21Z

Hello @vishalsodani,
Thank you very much for contributing to Meilisearch ❤️.
However, I am not available on the weekend, but I will be back on Monday 😊.

PS: This message was sent automatically!

bidoubiwa

Hey! Thanks for your contribution 🔥

I see that you are still in draft.

I made a small change request. Also .code-samples.meilisearch.yaml should be updated! Example here

tests/pagination.test.ts

vishalsodani · 2022-10-03T10:33:19Z

Hey! Thanks for your contribution fire

I see that you are still in draft.

I made a small change request. Also .code-samples.meilisearch.yaml should be updated! Example here

ok. Thanks.

I pushed as draft since I was not sure about the conformity of the tests I had written to the tests as written in other files like stop_words.test.ts.

For example,
describe.each([{ permission: 'Master' }, { permission: 'Private' }])

What is the Private permission?

bidoubiwa · 2022-10-03T10:47:47Z

Meilisearch has 1 master-key and 2 default keys. One being private that should have all rights except on the /keys route. To ensure that Meilisearch is working correctly we are doing some tests against Meilisearch in the SDK's.
So every test is ran using the master key and the private key!

vishalsodani · 2022-10-03T10:51:34Z

Meilisearch has 1 master-key and 2 default keys. One being private that should have all rights except on the /keys route. To ensure that Meilisearch is working correctly we are doing some tests against Meilisearch in the SDK's. So every test is ran using the master key and the private key!

ok. Thanks.

vishalsodani · 2022-10-03T13:14:24Z

Meilisearch has 1 master-key and 2 default keys. One being private that should have all rights except on the /keys route. To ensure that Meilisearch is working correctly we are doing some tests against Meilisearch in the SDK's. So every test is ran using the master key and the private key!

ok. But, locally I start a Meilisearch instance without any key. So, most of private tests are failing.

bidoubiwa · 2022-10-03T14:20:11Z

As per the contributing guide you'll have to add the --master-key masterKey flag when launching your Meilisearch to make the tests run correctly

bidoubiwa · 2022-10-03T14:36:50Z

Can you merge main into your branch and re-run the command to run Meilisearch? Meilisearch just released version v0.29

bidoubiwa · 2022-10-03T16:13:43Z

Missing for the moment:

code-samples file update
Readme specification (at the bottom) update

vishalsodani · 2022-10-03T17:22:18Z

Can you merge main into your branch and re-run the command to run Meilisearch? Meilisearch just released version v0.29

Done. Tests: 6 skipped, 1730 passed, 1736 total

bidoubiwa

Could you update the tests in settings.test.ts and add the check of this new field as well?

README.md

src/indexes.ts

tests/pagination.test.ts

.code-samples.meilisearch.yaml

src/indexes.ts

README.md

.code-samples.meilisearch.yaml

tests/pagination.test.ts

bidoubiwa · 2022-10-04T14:37:24Z

Could you run yarn style:fix to fix the styling issues?

bidoubiwa

Sorry to come back as often with reviews, since there are a lot of changes everything does not pop immediately.

tests/pagination.test.ts

src/indexes.ts

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

src/indexes.ts

bidoubiwa · 2022-10-04T15:44:29Z

Also, add them bottom of your testing file you are missing some tests. See example in #1344

vishalsodani · 2022-10-05T06:15:42Z

Sorry to come back as often with reviews, since there are a lot of changes everything does not pop immediately.

No issues.

vishalsodani · 2022-10-05T08:04:07Z

Also, add them bottom of your testing file you are missing some tests. See example in #1344

Done.

bidoubiwa

A part from these changes everything looks good :) Could you fix your styling errors?

.code-samples.meilisearch.yaml

tests/pagination.test.ts

vishalsodani · 2022-10-05T09:13:45Z

A part from these changes everything looks good :) Could you fix your styling errors?

Done.

bidoubiwa · 2022-10-05T09:44:10Z

bors try

meili-bors · 2022-10-05T09:47:39Z

try

Build succeeded:

bidoubiwa

LGTM 🔥🔥🔥🔥

bidoubiwa · 2022-10-05T10:00:38Z

bors merge

meili-bors · 2022-10-05T10:04:04Z

Build succeeded:

bidoubiwa · 2022-10-05T10:04:09Z

Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.

vishalsodani · 2022-10-05T10:14:25Z

Thanks again for contributing with Meilisearch heart If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.

Thanks for guiding me through the process! 😍 👏 @bidoubiwa

bidoubiwa suggested changes Oct 3, 2022

View reviewed changes

tests/pagination.test.ts Outdated Show resolved Hide resolved

vishalsodani marked this pull request as ready for review October 3, 2022 13:15

vishalsodani added 4 commits October 3, 2022 22:39

Add support to the pagination setting customization at the index level

fab60a8

fix test

2979516

update with pagination setting methods

a2db7e0

update README with pagination settings API definitions

7f2f7e7

vishalsodani force-pushed the pagination_setting branch from 4ac48ca to 7f2f7e7 Compare October 3, 2022 17:21

bidoubiwa suggested changes Oct 3, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

src/indexes.ts Outdated Show resolved Hide resolved

tests/pagination.test.ts Outdated Show resolved Hide resolved

tests/pagination.test.ts Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

bidoubiwa suggested changes Oct 3, 2022

View reviewed changes

src/indexes.ts Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

vishalsodani added 3 commits October 4, 2022 18:53

update README as per suggestions

32ee8f4

update get pagination

378dcc4

add settings guide for pagination in sample file

d169439

bidoubiwa suggested changes Oct 4, 2022

View reviewed changes

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Show resolved Hide resolved

tests/pagination.test.ts Outdated Show resolved Hide resolved

vishalsodani added 2 commits October 4, 2022 20:17

fix page settings declarations in the sample file

ff175ad

fix reset pagination test

11644ca

bidoubiwa suggested changes Oct 4, 2022

View reviewed changes

vishalsodani and others added 3 commits October 4, 2022 20:38

Update tests/pagination.test.ts

093dc4e

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

Update src/indexes.ts

a4c80e9

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

Update src/indexes.ts

3bafdb9

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>

bidoubiwa added the enhancement New feature or request label Oct 4, 2022

bidoubiwa reviewed Oct 4, 2022

View reviewed changes

src/indexes.ts Outdated Show resolved Hide resolved

bidoubiwa mentioned this pull request Oct 4, 2022

Update js-docs comment on enqueued tasks #1346

Closed

vishalsodani added 4 commits October 5, 2022 10:58

fix merge conflicts

a883695

fix tests, refactor to use new object, merge main branch

9de1976

add remaining tests

fcd7586

add settings test for pagination property

25cf8c4

bidoubiwa suggested changes Oct 5, 2022

View reviewed changes

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

.code-samples.meilisearch.yaml Outdated Show resolved Hide resolved

tests/pagination.test.ts Outdated Show resolved Hide resolved

fix style issues

61490c7

meili-bors bot added a commit that referenced this pull request Oct 5, 2022

Try #1339:

77a858b

bidoubiwa approved these changes Oct 5, 2022

View reviewed changes

meili-bors bot merged commit 8ae2369 into meilisearch:main Oct 5, 2022

bidoubiwa mentioned this pull request Oct 5, 2022

Add Vue 3 sample to getting started code sample meilisearch/meilisearch-vue#117

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to the pagination setting customization at the index level #1339

Add support to the pagination setting customization at the index level #1339

vishalsodani commented Oct 1, 2022 •

edited

Loading

bidoubiwa commented Oct 2, 2022

bidoubiwa left a comment •

edited

Loading

vishalsodani commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022 •

edited

Loading

vishalsodani commented Oct 3, 2022

vishalsodani commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022

vishalsodani commented Oct 3, 2022

bidoubiwa left a comment

bidoubiwa commented Oct 4, 2022

bidoubiwa left a comment

bidoubiwa commented Oct 4, 2022

vishalsodani commented Oct 5, 2022

vishalsodani commented Oct 5, 2022

bidoubiwa left a comment

vishalsodani commented Oct 5, 2022

bidoubiwa commented Oct 5, 2022

meili-bors bot commented Oct 5, 2022

bidoubiwa left a comment

bidoubiwa commented Oct 5, 2022

meili-bors bot commented Oct 5, 2022

bidoubiwa commented Oct 5, 2022

vishalsodani commented Oct 5, 2022

Add support to the pagination setting customization at the index level #1339

Add support to the pagination setting customization at the index level #1339

Conversation

vishalsodani commented Oct 1, 2022 • edited Loading

Pull Request

What does this PR do?

PR checklist

bidoubiwa commented Oct 2, 2022

bidoubiwa left a comment • edited Loading

Choose a reason for hiding this comment

vishalsodani commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022 • edited Loading

vishalsodani commented Oct 3, 2022

vishalsodani commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022

bidoubiwa commented Oct 3, 2022

vishalsodani commented Oct 3, 2022

bidoubiwa left a comment

Choose a reason for hiding this comment

bidoubiwa commented Oct 4, 2022

bidoubiwa left a comment

Choose a reason for hiding this comment

bidoubiwa commented Oct 4, 2022

vishalsodani commented Oct 5, 2022

vishalsodani commented Oct 5, 2022

bidoubiwa left a comment

Choose a reason for hiding this comment

vishalsodani commented Oct 5, 2022

bidoubiwa commented Oct 5, 2022

meili-bors bot commented Oct 5, 2022

try

bidoubiwa left a comment

Choose a reason for hiding this comment

bidoubiwa commented Oct 5, 2022

meili-bors bot commented Oct 5, 2022

bidoubiwa commented Oct 5, 2022

vishalsodani commented Oct 5, 2022

vishalsodani commented Oct 1, 2022 •

edited

Loading

bidoubiwa left a comment •

edited

Loading

bidoubiwa commented Oct 3, 2022 •

edited

Loading