Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capabilities to update documents by function #1691

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Add capabilities to update documents by function #1691

merged 8 commits into from
Aug 21, 2024

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Aug 18, 2024 •
edited
Loading

Pull Request

Related issue

Fixes #1686

What does this PR do?

  • Adds experimental updateDocumentsByFunction feature

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@flevi29 flevi29 requested a review from brunoocasali August 18, 2024 09:15
@flevi29 flevi29 changed the base branch from main to bump-meilisearch-v1.10.0 August 18, 2024 17:24
@flevi29
Copy link
Collaborator Author

flevi29 commented Aug 18, 2024

It seems to pull getmeili/meilisearch:latest instead of 1.10.

@flevi29 flevi29 changed the title Feature update documents by function feat(v1.10): Update documents by function Aug 19, 2024
@curquiza curquiza requested review from mdubus and removed request for brunoocasali August 20, 2024 13:17
@curquiza curquiza changed the title feat(v1.10): Update documents by function Add capabilities to pdate documents by function Aug 20, 2024
@curquiza curquiza changed the title Add capabilities to pdate documents by function Add capabilities to update documents by function Aug 20, 2024
@curquiza curquiza added the enhancement New feature or request label Aug 20, 2024
@curquiza curquiza mentioned this pull request Aug 20, 2024
Merged
mdubus
mdubus reviewed Aug 21, 2024
View reviewed changes
src/types/types.ts Outdated Show resolved Hide resolved
tests/documents.test.ts Outdated Show resolved Hide resolved
tests/documents.test.ts Outdated Show resolved Hide resolved
tests/utils/meilisearch-test-utils.ts Outdated Show resolved Hide resolved
mdubus
mdubus approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks a lot for your taking care of this 🤩 🚀

@mdubus mdubus merged commit 30e833f into meilisearch:bump-meilisearch-v1.10.0 Aug 21, 2024
6 checks passed
@curquiza curquiza mentioned this pull request Aug 21, 2024
Closed
2 tasks
@flevi29 flevi29 deleted the feature-update-documents-by-fn branch August 22, 2024 08:09
meili-bors bot added a commit that referenced this pull request Aug 26, 2024
@meili-bors @meili-bot
Merge #1695
bb4f53e 
1695: Update version for the next release (v0.42.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-js to a new version: "v0.42.0"

CHANGELOGS 👇

This version introduces features released on Meilisearch v1.10.0 🎉
Check out the changelog of [Meilisearch v1.10.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.10.0) for more information on the changes.

## ⚠️ Breaking changes

* Improve errors (#1656) `@/flevi29`
More details [here](#1656 (comment))
* Changes related to Hybrid search (experimental) for the REST embedder (#1692) `@/mdubus` 
  - Removed parameters: `query`, `inputField`, `inputType`, `pathToEmbeddings` and `embeddingObject`.
  - Replaced by `request` and `response`
  - New parameter: `headers`

## 🚀 Enhancements

* Hybrid search improvements (#1692) `@/mdubus` 
  - Add `url` parameter to the OpenAI embedder
  - `dimensions` is now available as an optional parameter for `ollama` embedders.

* Add federated search parameters (#1689) `@/flevi29` 

```js
client.multiSearch({
    federation: {},
    queries: [
      {
        indexUid: 'movies',
        q: 'batman',
        limit: 5,
      },
      {
        indexUid: 'comics',
        q: 'batman',
        limit: 5,
      },
    ]
  })
```

* Add capabilities to update documents by function (#1691) `@/flevi29` 
```js
index.updateDocumentsByFunction({
    context: { ctx: 'Harry' },
    filter: 'id = 4',
    function: 'doc.comment = `Yer a wizard, ${context.ctx}!`',
  })
)
```

* Add language settings (#1693) `@/flevi29` 
```js
client.index('INDEX_NAME').updateLocalizedAttributes([
    { attributePatterns: ['jpn'], locales: ['*_ja'] },
];)
```

* Add `locale` search parameter (#1693) `@/flevi29` 
```js
client.index('INDEX_NAME').search('進撃の巨人', { locales: ['jpn'] })
```

## ⚙️ Maintenance/misc

* Add JS hosted documentation (#1678) `@/amit-ksh`



Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
@KaliforniaShell KaliforniaShell mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubus mdubus mdubus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.10.0] Update documents by function
3 participants
@flevi29 @mdubus @curquiza