Fix and improve eslint config, other minor changes
#1795
Merged
+51
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flevi29
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 18 18
Lines 1546 1546
Branches 326 326
=======================================
Hits 1514 1514
Misses 32 32 ☔ View full report in Codecov by Sentry. |
Strift
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Hi @flevi29, thank you for this PR.
This is a welcome simplification of the eslint configuration.
It would have been simpler to review if the typescript part was made in a separate PR.
I left a small comment, but the rest seems good to me. Happy to merge after next week's releases.
meili-bors bot
added a commit
that referenced
this pull request
Jan 14, 2025
1826: Update version for the next release (v0.48.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-js to a new version: "v0.48.0" CHANGELOGS 👇 ##⚠️ Breaking changes * Improve `token.ts` and make it tree-shakeable (#1661) `@flevi29` **Migration** Replace: ```ts await generateTenantToken("74c9c733-3368-4738-bbe5-1d18a5fecb37", [], { apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99", expiresAt: new Date("December 17, 4000 03:24:00"), }); ``` By: ```ts await generateTenantToken({ apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99", apiKeyUid: "74c9c733-3368-4738-bbe5-1d18a5fecb37", searches: [], expiresAt: new Date("December 17, 4000 03:24:00"), }); ``` ## ⚙️ Maintenance * Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29` * Remove mention of support of Node 14 and 16 (#1805) `@\Strift` * Fix and improve `eslint` config, other minor changes (#1795) `@\flevi29` * Fix swapped args in localized-attributes sample (#1818) `@\ellnix` * [Playground] Replace Parcel by Vite (#1821) `@\Strift` * Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29` * Remove `nodemon` dependency (#1822) `@\flevi29` Thanks again to `@\Strift,` `@\ellnix,` and `@\flevi29` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
meili-bors bot
added a commit
that referenced
this pull request
Jan 14, 2025
1826: Update version for the next release (v0.48.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-js to a new version: "v0.48.0" CHANGELOGS 👇 ##⚠️ Breaking changes * Improve `token.ts` and make it tree-shakeable (#1661) `@flevi29` **Migration** Replace: ```ts await generateTenantToken("74c9c733-3368-4738-bbe5-1d18a5fecb37", [], { apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99", expiresAt: new Date("December 17, 4000 03:24:00"), }); ``` By: ```ts await generateTenantToken({ apiKey: "0a6e572506c52ab0bd6195921575d23092b7f0c284ab4ac86d12346c33057f99", apiKeyUid: "74c9c733-3368-4738-bbe5-1d18a5fecb37", searches: [], expiresAt: new Date("December 17, 4000 03:24:00"), }); ``` ## ⚙️ Maintenance * Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29` * Remove mention of support of Node 14 and 16 (#1805) `@\Strift` * Fix and improve `eslint` config, other minor changes (#1795) `@\flevi29` * Fix swapped args in localized-attributes sample (#1818) `@\ellnix` * [Playground] Replace Parcel by Vite (#1821) `@\Strift` * Switch from rollup to vite, from commonjs to ecmascript modules (#1740) `@\flevi29` * Remove `nodemon` dependency (#1822) `@\flevi29` Thanks again to `@\Strift,` `@\ellnix,` and `@\flevi29` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
eslintconfig was set up in a confusing way, now it's simplified and works as it shouldtypescriptdidn't check test files, now it doesPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!