Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding delete if exists methods #918

Merged
merged 2 commits into from
Jun 13, 2021
Merged

Adding delete if exists methods #918

merged 2 commits into from
Jun 13, 2021

Conversation

sanders41
Copy link
Contributor

bidoubiwa
bidoubiwa reviewed Jun 13, 2021
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
bidoubiwa
bidoubiwa reviewed Jun 13, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I was wondering if this routing system was confusing and I think it is. I'm going to remove it

@sanders41
Copy link
Contributor Author

Yes as soon as you said "MeiliSearch route" it become clear to me the purpose, but before that I wasn't so sure.

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 13, 2021

Build succeeded:

@bors bors bot merged commit 6fb9352 into meilisearch:main Jun 13, 2021
@sanders41 sanders41 deleted the delete_if_exists branch June 13, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanders41 @bidoubiwa