Update tests based on PHPstan feedback

meilisearch · Dec 4, 2024 · aab82ed · aab82ed
1 parent 2e409e3
commit aab82ed
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 23 deletions.
diff --git a/src/Contracts/BatchesQuery.php b/src/Contracts/BatchesQuery.php
@@ -17,11 +17,6 @@ class BatchesQuery
      */
     private ?int $limit = null;
 
-    /**
-     * @var non-empty-list<int>|null
-     */
-    private ?array $canceledBy = null;
-
     private ?bool $reverse = null;
 
     /**
@@ -34,18 +29,6 @@ public function setFrom(int $from): self
         return $this;
     }
 
-    /**
-     * @param non-empty-list<int> $canceledBy
-     *
-     * @return $this
-     */
-    public function setCanceledBy(array $canceledBy): self
-    {
-        $this->canceledBy = $canceledBy;
-
-        return $this;
-    }
-
     /**
      * @return $this
      */

diff --git a/tests/Endpoints/BatchesTest.php b/tests/Endpoints/BatchesTest.php
@@ -22,7 +22,7 @@ protected function setUp(): void
     public function testGetAllBatches(): void
     {
         $response = $this->client->getBatches();
-        self::assertIsArray($response->getResults());
+        self::assertGreaterThan(0, $response->getTotal());
     }
 
     public function testGetAllBatchesWithIndexUidFilters(): void
@@ -37,19 +37,19 @@ public function testGetAllBatchesWithTasksFilters(): void
     {
         $tasks = $this->client->getTasks(new TasksQuery())->getResults();
         $response = $this->client->getBatches((new BatchesQuery())->setUids([$tasks[0]['uid']]));
-        self::assertNotNull($response->getResults());
+        self::assertGreaterThan(0, $response->getTotal());
     }
 
     public function testGetAllBatchesInReverseOrder(): void
     {
         $startDate = new \DateTimeImmutable('now');
 
         $batches = $this->client->getBatches((new BatchesQuery())
-            ->setAfterEnqueuedAt($startDate)
+                ->setAfterEnqueuedAt($startDate)
         );
         $reversedBatches = $this->client->getBatches((new BatchesQuery())
-            ->setAfterEnqueuedAt($startDate)
-            ->setReverse(true)
+                ->setAfterEnqueuedAt($startDate)
+                ->setReverse(true)
         );
         self::assertSame($batches->getResults(), array_reverse($reversedBatches->getResults()));
     }

diff --git a/tests/Endpoints/TasksTest.php b/tests/Endpoints/TasksTest.php
@@ -85,7 +85,7 @@ public function getAllTasksClientWithBatchFilter(): void
                 ->setBatchUid($task['uid'])
         );
 
-        self::assertIsArray($response->getResults());
+        self::assertGreaterThan(0, $response->getTotal());
     }
 
     public function testGetOneTaskIndex(): void