-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chainable setReverse()
method to get tasks in reverse order
#698
Conversation
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
Hello @norkunas and thanks for the early review 👋 I forgot to set the PR as a draft. I applied all your suggestions. Thanks! We're now ready for a new review. It looks like the test is flaky though, because it failed at first; and worked when I re-ran it. I'm not sure how I can make it better. If you have feedback, it's welcome. |
Hey 👋
Which tasks does it retrieve? Because I don't see that index would be seeded? |
Oh looks like that after each test the index is not cleared, so it sees previous tests data 😑 |
Would you recommend updating the tests or do you think it's sufficient as is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you recommend updating the tests or do you think it's sufficient as is?
I'd at least add a (todo) note that these tests should be refactored to cleanup after themself
setReverse()
method to get tasks in reverse order
Pull Request
Related issue
Fixes #693
Thank you so much for contributing to Meilisearch!