Fix tests by passing embedder
#1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bors bot
added a commit
that referenced
this pull request
Sep 30, 2024
1020: Fix tests by passing embedders r=sanders41 a=dureuill # Pull Request ## Related issue Fixes #1019 ## What does this PR do? - Change comment stating the default model for OpenAI - Add `document_template_max_bytes` to models - Fix tests Co-authored-by: Louis Dureuil <louis@meilisearch.com>
|
Build failed: |
dureuill
changed the title
embedder
|
ah, the tests don't pass against the latest meili because it doesn't have (yet) well at least we're ready 😄 |
|
Yes. @curquiza I assume it is OK for me to manually merge this instead of using bors? Bors is trying to test against latest release. |
|
yes manually merge is needed here 😉 |
2 tasks
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1019
What does this PR do?
document_template_max_bytesto models