Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code sample v0.23.0 #331

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Update code sample v0.23.0 #331

merged 2 commits into from
Oct 11, 2021

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Oct 6, 2021

No description provided.

@alallema alallema marked this pull request as ready for review October 7, 2021 20:58
@alallema alallema changed the title Update code sample Update code sample v0.23.0 Oct 7, 2021
@alallema alallema requested a review from bidoubiwa October 11, 2021 09:11
@alallema alallema merged commit 90430bf into bump-meilisearch-v0.23.0 Oct 11, 2021
@alallema alallema deleted the code-sample branch October 11, 2021 09:14
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Oct 11, 2021
bors bot added a commit that referenced this pull request Oct 12, 2021
327: Changes related to the next MeiliSearch release (v0.23.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#142

This PR:
- gathers the changes related to the next MeiliSearch release (v0.23.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases).
- might eventually contain test failures until the MeiliSearch v0.23.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.23.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #329 
    - Add new methods:
        - `addDocumentsJson(string $documents, ?string $primaryKey = null)`
        - `addDocumentsNdJson(string $documents, ?string $primaryKey = null)`
        - `addDocumentsCsv(string $documents, ?string $primaryKey = null)`
    - Add tests for new methods
    - Remove json header `application/json` for every http methods
- #331 

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant