Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApiKey name not conform for pylint #386

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Fix ApiKey name not conform for pylint #386

merged 2 commits into from
Jan 5, 2022

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Jan 5, 2022 •
edited
Loading

BreakingChanges

apiKey is modified on the client argument to conform to pylint in api_key.

What does this PR do?

Fixes pylint error for PR #369

@alallema alallema added the breaking-change The related changes are breaking for the users label Jan 5, 2022
@alallema alallema changed the title Fix name not conform fro pylint Fix ApiKey name not conform for pylint Jan 5, 2022
@alallema alallema changed the base branch from bump-meilisearch-v0.25.0 to main January 5, 2022 12:41
@alallema alallema requested a review from curquiza January 5, 2022 12:50
curquiza
curquiza approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@alallema
Copy link
Contributor Author

alallema commented Jan 5, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 5, 2022

Build succeeded:

@bors bors bot merged commit 2a2a757 into main Jan 5, 2022
@bors bors bot deleted the fix-pylint branch January 5, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alallema @curquiza