Fix reported type of decorator #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bors bot
added a commit
that referenced
this pull request
May 2, 2024
956: Fix reported type of decorator r=curquiza a=sanders41 # Pull Request ## Related issue Fixes #<issue_number> Reported on Discord https://discord.com/channels/1006923006964154428/1006923007559729154/1235605897418506401 The Return type is getting swallowed by the `version_error_hint_message` decorator.  ## What does this PR do? - Uses a generic instead of `Any` for the decorator. After the update:  ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Paul Sanders <paul@paulsanders.dev>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Required status check \"Yaml linting check\" is in progress.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #<issue_number>
Reported on Discord https://discord.com/channels/1006923006964154428/1006923007559729154/1235605897418506401
The Return type is getting swallowed by the
version_error_hint_messagedecorator.What does this PR do?
Anyfor the decorator.After the update:
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!