Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document and vector fixture #963

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix document and vector fixture #963

merged 2 commits into from
May 22, 2024

Conversation

sanders41
Copy link
Collaborator

Pull Request

In looking at #962 I noticed that the index_with_documents_and_vectors fixture was not working as expected and therefore the test_vector_search test was not testing what was expected. Because only one document had vectors the document addition task was failing and no documents were added to the index. So test_vector_search was returning no hits because there were no documents in the index. This updates the fixutre to add vectors to all documents, and updates the test to pass with the new results.

Related issue

Fixes #<issue_number>

What does this PR do?

  • Fixes the test_vector_search test.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 requested a review from curquiza May 21, 2024 21:19
@curquiza curquiza added bug Something isn't working maintenance Anything related to maintenance (CI, tests, refactoring...) and removed bug Something isn't working labels May 22, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @sanders41

bors merge

Copy link
Contributor

meili-bors bot commented May 22, 2024

@meili-bors meili-bors bot merged commit 75860f8 into main May 22, 2024
11 checks passed
@meili-bors meili-bors bot deleted the fix-test branch May 22, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants