Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
In looking at #962 I noticed that the
index_with_documents_and_vectors
fixture was not working as expected and therefore thetest_vector_search
test was not testing what was expected. Because only one document had vectors the document addition task was failing and no documents were added to the index. Sotest_vector_search
was returning no hits because there were no documents in the index. This updates the fixutre to add vectors to all documents, and updates the test to pass with the new results.Related issue
Fixes #<issue_number>
What does this PR do?
test_vector_search
test.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!