Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added search cutoff ms settings #964

Merged
merged 1 commit into from
May 28, 2024
Merged

Added search cutoff ms settings #964

merged 1 commit into from
May 28, 2024

Conversation

the-sinner
Copy link
Contributor

Pull Request

Related issue

Fixes #959

What does this PR do?

  • adds the search cutoff ms settings

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@the-sinner the-sinner marked this pull request as draft May 28, 2024 16:26
@the-sinner the-sinner marked this pull request as ready for review May 28, 2024 16:30
sanders41
sanders41 requested changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @the-sinner! Just a couple minor updates requested.

meilisearch/index.py Outdated Show resolved Hide resolved
meilisearch/index.py Outdated Show resolved Hide resolved
meilisearch/index.py Show resolved Hide resolved
sanders41
sanders41 approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented May 28, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit da08f26 into meilisearch:main May 28, 2024
11 checks passed
@curquiza curquiza added the enhancement New feature or request label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.8] Support searchCutoffMs setting
3 participants
@the-sinner @sanders41 @curquiza