Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a custom serializer for documents #974

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Allow passing a custom serializer for documents #974

merged 4 commits into from
Jun 10, 2024

Conversation

sanders41
Copy link
Collaborator

@sanders41 sanders41 commented Jun 9, 2024 •
edited
Loading

Pull Request

@LaundroMat FYI in case you want to test this to see if it solves your issue.

Related issue

Fixes #973

What does this PR do?

  • Allows passing a custom JSONEncoder to serialize documents with types that the default encoder can't handle.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the enhancement New feature or request label Jun 9, 2024
@sanders41 sanders41 requested a review from curquiza June 9, 2024 19:33
curquiza
curquiza previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks niiiiiice

Do you think we should add a small part about this in the ReADME, or is it "obvious" enough for python community, and the docs is enough?

@sanders41
Copy link
Collaborator Author

Most people will probably not have created a custom encoder before so I added it to the readme.

curquiza
curquiza approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo bien!

@sanders41
Copy link
Collaborator Author

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jun 10, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 739a22e into main Jun 10, 2024
11 checks passed
@meili-bors meili-bors bot deleted the custom-encoder branch June 10, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON serializer cannot serialize UUID values
2 participants
@sanders41 @curquiza