Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #978

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Fix flaky test #978

merged 1 commit into from
Jun 14, 2024

Conversation

sanders41
Copy link
Collaborator

Pull Request

@curquiza since the test is flaky there is a chance this doesn't fix the issue, but I'm pretty sure it will.

Related issue

Fixes #976

What does this PR do?

  • Remove HuggingFace from settings test

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jun 13, 2024
@sanders41 sanders41 requested a review from curquiza June 13, 2024 21:49
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean we don't handle huggingface embedder on the python side?

my mistake, it's only on test side

@sanders41
Copy link
Collaborator Author

bors merge

Copy link
Contributor

meili-bors bot commented Jun 14, 2024

@meili-bors meili-bors bot merged commit 1a52721 into main Jun 14, 2024
11 checks passed
@meili-bors meili-bors bot deleted the flaky-test branch June 14, 2024 10:33
meili-bors bot added a commit that referenced this pull request Jul 11, 2024
994: Remove huggingface setting in tests to fix flakiyness r=curquiza a=sanders41

# Pull Request

The HuggingFace embedder was removed from tests in #978, but I found some more places it was being tested. I was able to get the tests to fail locally like they are in CI with HuggingFace present. Since removing the additional HuggingFace tests I haven't been able to get them to fail again locally.

## Related issue
Fixes #976

## What does this PR do?
- Removes HuggingFace embedder from tests to fix flakiness.

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Paul Sanders <paul@paulsanders.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings tests in CI have become flaky
2 participants