Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant Calls to sleep in the Test Suite #291

Closed
ellnix opened this issue Sep 27, 2023 · 0 comments · Fixed by #292
Closed

Redundant Calls to sleep in the Test Suite #291

ellnix opened this issue Sep 27, 2023 · 0 comments · Fixed by #292

Comments

@ellnix
Copy link
Collaborator

ellnix commented Sep 27, 2023

Description
There is a pattern in the test suite where there is a sleep call right after a synchronous reindex!. This happens four times in spec/integration_spec.rb, but they are RSpec before blocks so they run more times than that.

Removing these sleep calls does not fail any test (the reindex! operations are already synchronous) and it brings the time it takes to run all tests from ~32s to ~12s (on my machine).
@ellnix ellnix changed the title Improve Test Suite Performance Redundant Calls to sleep in the Test Suite Sep 27, 2023
@ellnix ellnix mentioned this issue Sep 27, 2023
Merged
3 tasks
meili-bors bot added a commit that referenced this issue Oct 6, 2023
@meili-bors @ellnix
Merge #292
bf2b82e 
292: Remove redundant calls to sleep in tests r=brunoocasali a=ellnix

# Pull Request

## Related issue
Fixes #291 

## What does this PR do?

## PR checklist
Please check if your PR fulfills the following requirements:
- [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [X] Have you read the contributing guidelines?
- [X] Have you made sure that the title is accurate and descriptive of the changes?



Co-authored-by: ellnix <103502144+ellnix@users.noreply.github.com>
@meili-bors meili-bors bot closed this as completed in b63cb6c Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant calls to sleep in tests ellnix/meilisearch-rails
1 participant
@ellnix