Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Analytics #179

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Feature/Analytics #179

merged 3 commits into from
Aug 1, 2022

Conversation

brunoocasali
Copy link
Member

Merge after meilisearch/meilisearch-ruby#354

With both PRs, we can send a custom header with the name of this gem according to meilisearch/integration-guides#150.

@brunoocasali brunoocasali added the enhancement New feature or request label Jul 29, 2022
@brunoocasali brunoocasali mentioned this pull request Jul 29, 2022
Closed
20 tasks
alallema
alallema previously approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍙

bidoubiwa
bidoubiwa approved these changes Aug 1, 2022
View reviewed changes
Copy link

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@brunoocasali
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 1, 2022

Build succeeded:

@bors bors bot merged commit ce8a253 into main Aug 1, 2022
@bors bors bot deleted the feature/custom-analytics branch August 1, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@alallema alallema alallema left review comments

@mdubus mdubus Awaiting requested review from mdubus

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunoocasali @alallema @bidoubiwa