-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when you make missing attribute searchable #293
Warn when you make missing attribute searchable #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @ellnix, for all of your work here!
I made some comments I would like you to reevaluate before we can merge this.
I believe I fixed the issues suggested, I had made some really strange decisions on this PR. I also removed one place where I used the new ruby 3 method definition syntax which would have broken compatibility with ruby 2.x in the test suite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 88.58% 88.73% +0.15%
==========================================
Files 10 10
Lines 648 657 +9
==========================================
+ Hits 574 583 +9
Misses 74 74
☔ View full report in Codecov by Sentry. |
Nice, as soon you fix them we will be good to go, thanks a lot for your effort @ellnix! |
f751075
to
ec38983
Compare
@brunoocasali this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellnix thanks for this fix 🎉
Thanks a lot for your patience and your smart work here ❤️
ec38983
to
645cf76
Compare
bors merge |
Pull Request
Related issue
Fixes #168
What does this PR do?
#logger
method toMeiliSearch::Rails
which is similar to Rails having its ownRails#logger
PR checklist
Please check if your PR fulfills the following requirements: