Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when warning about pagy configuration redundancy #295

Conversation

ellnix
Copy link
Collaborator

@ellnix ellnix commented Sep 28, 2023

Pull Request

Related issue

Fixes #294

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5ad4d1) 89.04% compared to head (1331d3f) 89.04%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files          10       10           
  Lines         657      657           
=======================================
  Hits          585      585           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ellnix ellnix force-pushed the fix-error-when-warning-about-pagy-redundancy branch from b264208 to f8cfd39 Compare November 1, 2023 17:13
brunoocasali
brunoocasali previously approved these changes Nov 3, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunoocasali brunoocasali added the bug Something isn't working label Nov 3, 2023
@ellnix ellnix force-pushed the fix-error-when-warning-about-pagy-redundancy branch from f8cfd39 to 1331d3f Compare December 11, 2023 09:59
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors bot merged commit ccbd9ce into meilisearch:main Dec 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to non-existant method Rails::Logger.warning (should be warn)
2 participants