Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply changes after the review #285

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Apply changes after the review #285

merged 2 commits into from
Jan 12, 2022

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jan 11, 2022 •
edited
Loading

Changes following the @brunoocasali review: #273 (review)

⚠️ I did not apply the spec convention everywhere, should be fixed via this issue #284

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 11, 2022
@curquiza curquiza requested a review from brunoocasali January 11, 2022 16:16
@curquiza curquiza force-pushed the changes-after-review branch from 5577df1 to 119f693 Compare January 11, 2022 17:27
brunoocasali
brunoocasali approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@curquiza curquiza merged commit 982dc58 into bump-meilisearch-v0.25.0 Jan 12, 2022
@curquiza curquiza deleted the changes-after-review branch January 12, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @brunoocasali