Feature/Analytics #292
Merged
Feature/Analytics #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
feature/analytics
branch
from
081eef7 to
019b083
Compare
brunoocasali
force-pushed
the
feature/analytics
branch
from
436af86 to
b4d5336
Compare
curquiza
reviewed
Jan 27, 2022
meili-bors bot
added a commit
that referenced
this pull request
Jan 27, 2022
295: Simplify headers handling r=brunoocasali a=brunoocasali This improvement creates a new attr to be instantiated during the initializer phase and after the instantiation, it could not be updated directly, just copies of it using `dup`. This should simplify the headers handling since they were mixed with options. Originally extracted from #292 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
curquiza
reviewed
Jan 27, 2022
brunoocasali
force-pushed
the
feature/analytics
branch
from
b4d5336 to
8154e1f
Compare
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Jan 27, 2022
292: Feature/Analytics r=brunoocasali a=brunoocasali - Add `User-Agent` inside the pre-defined headers Add ruby support as requested here meilisearch/integration-guides#150 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors try |
tryBuild succeeded: |
This commit also exposes a way to add any other header to the request
brunoocasali
force-pushed
the
feature/analytics
branch
from
8154e1f to
d042ce9
Compare
|
bors merge |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Agentinside the pre-defined headersAdd ruby support as requested here meilisearch/integration-guides#150