-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task api for v0.28.0 #299
Update task api for v0.28.0 #299
Conversation
fd3d171
to
d21ac0e
Compare
d21ac0e
to
61be5a5
Compare
704f22e
to
f46f78d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done !!! 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a comment I don't understand what is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing !!! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well Done! 🎉
LGTM ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
Pull Request
Related to: meilisearch/integration-guides#205
Breaking
TaskInfo
and not aTask
object anymore. (ex: add_documents).get_tasks
now returns aTasksResults
where the tasks are contained inside theresults
field.task_id
inTask
andTaskInfo
is now au32
instead of au64
index_uid
inTask
andTaskInfo
is now an Optionnal.documentAddition
is replaced withDocumentAdditionOrUpdate
get_tasks
based of this usinglimit
,from
,next
metadata in the response.get_tasks
onindexUid
,status
andtype
.//
get_tasks
//
get_tasks_with
// get tasks using
execute
Routes changes
index.get_task
&index.wait_for_task
now useGET /tasks/:task_uid