-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTTP methods for v0.28.0 #312
Merged
bidoubiwa
merged 33 commits into
bump-meilisearch-v0.28.0
from
update_http_methods_for_v0.28.0
Aug 22, 2022
Merged
Update HTTP methods for v0.28.0 #312
bidoubiwa
merged 33 commits into
bump-meilisearch-v0.28.0
from
update_http_methods_for_v0.28.0
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
skip-changelog
The PR will not appear in the release changelogs
label
Aug 3, 2022
…meilisearch-rust into update_http_methods_for_v0.28.0
…meilisearch-rust into update_http_methods_for_v0.28.0
bidoubiwa
requested review from
irevoire,
brunoocasali and
alallema
and removed request for
brunoocasali
August 3, 2022 15:01
alallema
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
…isearch/meilisearch-rust into update_http_methods_for_v0.28.0
…isearch/meilisearch-rust into update_http_methods_for_v0.28.0
…hub.com/meilisearch/meilisearch-rust into update_http_methods_for_v0.28.0
Base automatically changed from
update_task_api_for_v0.28.0
to
bump-meilisearch-v0.28.0
August 22, 2022 11:35
alallema
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to the
HTTP
verbsRelated to:
To be more compliant with the RESTful good practices we must change the following verbs:
PATCH
/indexes/{indexUid}
instead ofPUT
PATCH
/indexes/{indexUid}/settings
instead ofPOST
PATCH
/indexes/{indexUid}/settings/typo-tolerance
instead ofPOST
PUT
/indexes/{indexUid}/settings/displayed-attributes
instead ofPOST
PUT
/indexes/{indexUid}/settings/distinct-attribute
instead ofPOST
PUT
/indexes/{indexUid}/settings/filterable-attributes
instead ofPOST
PUT
/indexes/{indexUid}/settings/ranking-rules
instead ofPOST
PUT
/indexes/{indexUid}/settings/searchable-attributes
instead ofPOST
PUT
/indexes/{indexUid}/settings/sortable-attributes
instead ofPOST
PUT
/indexes/{indexUid}/settings/stop-words
instead ofPOST
PUT
/indexes/{indexUid}/settings/synonyms
instead ofPOST