Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meilisearch#499 (attributesToSearchOn) #510

Merged
merged 1 commit into from
Sep 12, 2023
Merged

meilisearch#499 (attributesToSearchOn) #510

merged 1 commit into from
Sep 12, 2023

Conversation

brendon-shf
Copy link
Contributor

Pull Request

Related issue

Fixes #499

What does this PR do?

  • adds support for the attributesToSearchOn (which was added in meilisearch v1.3) to the rust client as with_attributes_to_search_on

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@brendon-shf brendon-shf changed the title meilisearch#499 (withAttributesToSearchOn) meilisearch#499 (attributesToSearchOn) Sep 2, 2023
@curquiza curquiza requested a review from a team September 12, 2023 09:08
Kerollmops
Kerollmops approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's wonderful, thank you ❤️
I'll let @irevoire merge!

irevoire
irevoire approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 12, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit d74e2bb into meilisearch:main Sep 12, 2023
7 checks passed
@curquiza curquiza added the enhancement New feature or request label Sep 12, 2023
@curquiza curquiza mentioned this pull request Sep 12, 2023
Merged
meili-bors bot added a commit that referenced this pull request Sep 12, 2023
@meili-bors @curquiza
Merge #519
7dd3bd2 
519: Update version for v0.24.2 r=curquiza a=curquiza

## 🚀 Enhancements

* Re-export public structures for better import path (#493) `@adriantombu`
* Added function for sending NDJSON documents (#494) `@carlosb1`
* Add missing startedAt field in EnqueuedTask (#485) `@sebastiantoh`
* #499 (attributesToSearchOn) (#510) `@brendon-shf`
* Add total field to get-tasks route (#509) `@hmacr`
* Implement client for experimental-features API (#516) `@hmacr`


Co-authored-by: curquiza <clementine@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.3] Define fields to search on at search-time (attributesToSearchOn)
4 participants
@brendon-shf @Kerollmops @irevoire @curquiza