Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for language settings and search parameter #620

Merged

Conversation

necocen
Copy link
Contributor

@necocen necocen commented Oct 11, 2024

Pull Request

Related issue

Fixes #611

What does this PR do?

  • Added locales parameter and with_locales method to SearchQuery struct
  • Added localized attributes related methods to Index and Settings
  • Added tests
  • Added code samples
    • search_parameter_reference_locales_1
    • get_localized_attribute_settings_1
    • update_localized_attribute_settings_1
    • reset_localized_attribute_settings_1

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@necocen necocen marked this pull request as ready for review October 11, 2024 12:07
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @necocen

Thank you for the work!

Bors merge

meili-bors bot added a commit that referenced this pull request Dec 3, 2024
620: Add support for language settings and search parameter r=ManyTheFish a=necocen

# Pull Request

## Related issue
Fixes #611 

## What does this PR do?
- Added `locales` parameter and `with_locales` method to `SearchQuery` struct
- Added localized attributes related methods to `Index` and `Settings`
- Added tests
- Added code samples
    - search_parameter_reference_locales_1
    - get_localized_attribute_settings_1
    - update_localized_attribute_settings_1
    - reset_localized_attribute_settings_1

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: necocen <necocen@gmail.com>
Copy link
Contributor

meili-bors bot commented Dec 3, 2024

Build failed:

@curquiza
Copy link
Member

curquiza commented Dec 3, 2024

bors try

meili-bors bot added a commit that referenced this pull request Dec 3, 2024
Copy link
Contributor

meili-bors bot commented Dec 3, 2024

try

Build failed:

@necocen
Copy link
Contributor Author

necocen commented Jan 8, 2025

I'm waiting for #625 to be merged (as it contains a fix for the clippy error)

@curquiza
Copy link
Member

curquiza commented Jan 9, 2025

bors merge

meili-bors bot added a commit that referenced this pull request Jan 9, 2025
620: Add support for language settings and search parameter r=curquiza a=necocen

# Pull Request

## Related issue
Fixes #611 

## What does this PR do?
- Added `locales` parameter and `with_locales` method to `SearchQuery` struct
- Added localized attributes related methods to `Index` and `Settings`
- Added tests
- Added code samples
    - search_parameter_reference_locales_1
    - get_localized_attribute_settings_1
    - update_localized_attribute_settings_1
    - reset_localized_attribute_settings_1

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: necocen <necocen@gmail.com>
Copy link
Contributor

meili-bors bot commented Jan 9, 2025

Build failed:

@curquiza
Copy link
Member

curquiza commented Jan 9, 2025

bors merge

Copy link
Contributor

meili-bors bot commented Jan 9, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit b554e44 into meilisearch:main Jan 9, 2025
6 of 7 checks passed
@curquiza curquiza added the enhancement New feature or request label Jan 9, 2025
@necocen necocen deleted the feature/add-support-for-language-settings branch January 11, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.10.0] Language settings & search parameter
3 participants