Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting in tests and demos folder #137

Closed
bidoubiwa opened this issue Jun 8, 2021 · 2 comments · Fixed by #150
Closed

Add linting in tests and demos folder #137

bidoubiwa opened this issue Jun 8, 2021 · 2 comments · Fixed by #150
Labels
good first issue Good for newcomers

Comments

@bidoubiwa
Copy link
Contributor

as pr #134 a linter is introduced but only in the source code. For consistency Tests and Demos folder should be lint-ed as well.

@curquiza curquiza added the good first issue Good for newcomers label Jun 8, 2021
@ppamorim
Copy link
Contributor

I will have to disable the lint Explicit Type Interface Violation because it's giving a false positive on Swift 5.4, here. Is that ok?

@ppamorim ppamorim linked a pull request Jun 29, 2021 that will close this issue
@bidoubiwa
Copy link
Contributor Author

Ah that's a shame! Yes lets disable it. Could you make a comment next to the rule in the config file explaining the false positive and maybe also a small issue explaining the issue so that we can track future updates of swiflint and update it when it is fixed?

If you prefer not I can do the PR and the issue no problem :) Thanks for investigating !

@bors bors bot closed this as completed in #150 Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants