-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all swiftlint errors and remove Tests from the linter #134
Conversation
fb91ae9
to
88565ba
Compare
Any idea why the checks are being cancelled? Internal error? |
@curquiza I had to update Xcode to 12.4 to support |
- PerfectDemo/.build | ||
- Demos/VaporDemo | ||
- Demos/PerfectDemo | ||
- Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we exclude these folders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need swiftlint in the demos and tests folder at the moment. I can open a new PR to sort them all later and reintroduce them back to the swiftlint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, really sorry @ppamorim but linting is bound to a project as a whole not only the source code. It creates consistency and makes contributing easier.
It would be weird if I don't have to follow the same rules in the tests folder than in the source folder.
Thanks a lot for this PR! Sorry for the delay |
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors merge |
Build succeeded: |
Hi,
In this PR I fixed all swiftlint errors and removed the Tests and Demos folder for the linter, this sorts the issue #97.
I did fix the errors in points of the code that are going to be removed, as listed on #133.
My local linter is on the latest version 0.42.0.
Multiple linter fixes applied by running
swiftlint autocorrect
.Regards.