Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove linter warnings #97

Closed
curquiza opened this issue Dec 21, 2020 · 1 comment · Fixed by #134
Closed

Remove linter warnings #97

curquiza opened this issue Dec 21, 2020 · 1 comment · Fixed by #134
Labels
good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

There is some linter warning we can see at each PR: https://github.com/meilisearch/meilisearch-swift/pull/96/files

This issue is to make them desappear.

Please, feel free to ask any question if not clear 🙂
@curquiza curquiza added good first issue Good for newcomers SDK Swift labels Dec 21, 2020
@ppamorim
Copy link
Contributor

ppamorim commented May 3, 2021

Yes I need to remove the linter checks for the unit tests. I will do it soon.

@ppamorim ppamorim mentioned this issue May 19, 2021
Merged
@ppamorim ppamorim linked a pull request May 19, 2021 that will close this issue
Fix all swiftlint errors and remove Tests from the linter #134
Merged
bors bot added a commit that referenced this issue Jun 8, 2021
@bors @ppamorim
Merge #134
b773f1c 
134: Fix all swiftlint errors and remove Tests from the linter r=bidoubiwa a=ppamorim

Hi,

In this PR I fixed all swiftlint errors and removed the Tests and Demos folder for the linter, this sorts the issue #97.
I did fix the errors in points of the code that are going to be removed, as listed on #133.

My local linter is on the latest version 0.42.0.

Multiple linter fixes applied by running `swiftlint autocorrect`.

Regards.

Co-authored-by: Pedro Paulo de Amorim <pp.amorim@hotmail.com>
Co-authored-by: Pedro Paulo Amorim <pp.amorim@hotmail.com>
@bors bors bot closed this as completed in #134 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix all swiftlint errors and remove Tests from the linter meilisearch/meilisearch-swift
2 participants
@ppamorim @curquiza