Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method to delete the index only if it already exists #208

Closed
2 tasks done
curquiza opened this issue Oct 6, 2021 · 0 comments · Fixed by #232
Closed
2 tasks done

Add a method to delete the index only if it already exists #208

curquiza opened this issue Oct 6, 2021 · 0 comments · Fixed by #232
Labels
good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

curquiza commented Oct 6, 2021 •
edited by bidoubiwa
Loading

Trying to delete an index that does not exist on the MeiliSearch server will throw an error. To delete it without any error no matter what if it exists or not, we need a new method.

  • Add a method delete_index_if_exists: it deletes the index but does not throw any error if the index does not exist.
  • Add tests

Example: https://github.com/meilisearch/meilisearch-python/pull/268/files

⚠️ This issue is generated, and delete_index_if_exists might be named differently in this package. Keep the already existing way of naming in this package to stay idomatic with the language and the repository.

Related to meilisearch/integration-guides#107

Sorry if this is already partially/completely implemented, feel free to let me know about the state of this issue.
brunoocasali added a commit to brunoocasali/meilisearch-swift that referenced this issue Nov 11, 2021
@brunoocasali
Add a new function deleteIfExists -> Bool
59738bc 
Closes meilisearch#208
@brunoocasali brunoocasali mentioned this issue Nov 11, 2021
Merged
3 tasks
brunoocasali added a commit to brunoocasali/meilisearch-swift that referenced this issue Nov 11, 2021
@brunoocasali
Add a new function deleteIfExists -> Bool
9111d01 
Closes meilisearch#208
brunoocasali added a commit to brunoocasali/meilisearch-swift that referenced this issue Nov 11, 2021
@brunoocasali
Add a new function deleteIfExists -> Bool
acad04a 
Closes meilisearch#208
bors bot added a commit that referenced this issue Nov 11, 2021
@bors @brunoocasali
Merge #232
496a0d6 
232: Add a new function deleteIfExists r=bidoubiwa a=brunoocasali

## What does this PR do?
Fixes #208

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!


Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
bors bot added a commit that referenced this issue Nov 11, 2021
@bors @brunoocasali
Merge #232
4fde150 
232: Add a new function deleteIfExists r=bidoubiwa a=brunoocasali

## What does this PR do?
Fixes #208

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!


Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@bors bors bot closed this as completed in 3a718c8 Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a new function deleteIfExists brunoocasali/meilisearch-swift
2 participants
@curquiza @meili-bot