Drop dumps #311
Merged
Drop dumps #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
reviewed
Aug 2, 2022
Comment on lines
+19
to
+20
| { "taskUid": 278, "indexUid": null, "status": "enqueued", "type": "dumpCreation", "enqueuedAt": "2022-07-21T21:43:12.419917471Z" } | ||
| """ |
There was a problem hiding this comment.
Do you prefer this compact formating ?
There was a problem hiding this comment.
Yeah, I'm evaluating the best way to maintain this kind of test, but I'm 100% sure the type of format will not impact the ability to read the tests. Btw in multiple cases, these data didn't make any difference in the result :|
There was a problem hiding this comment.
Yes, I think it is more readable when it is in multiple lines but you decide!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumptype.Client#getDumpStatusmethod.Client#createDumpto return a Result instead ofDump.