Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexes changes #314

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Indexes changes #314

merged 1 commit into from
Aug 4, 2022

Conversation

brunoocasali
Copy link
Member

  • Add IndexesQuery type to handle the indexes endpoints parameters.
  • Add IndexesResults type to handle the object response in the GET /indexes response.
  • Change responses in the create/update/delete actions for documents to return TaskInfo.

@brunoocasali brunoocasali requested a review from bidoubiwa August 2, 2022 18:23
bidoubiwa
bidoubiwa reviewed Aug 3, 2022
View reviewed changes
Sources/MeiliSearch/Indexes.swift Show resolved Hide resolved
Sources/MeiliSearch/Indexes.swift Show resolved Hide resolved
Sources/MeiliSearch/Indexes.swift Show resolved Hide resolved
Sources/MeiliSearch/Indexes.swift Show resolved Hide resolved
Sources/MeiliSearch/Indexes.swift Show resolved Hide resolved
Sources/MeiliSearch/Indexes.swift Show resolved Hide resolved
Sources/MeiliSearch/Model/IndexesResults.swift Show resolved Hide resolved
@brunoocasali brunoocasali requested a review from bidoubiwa August 3, 2022 14:18
bidoubiwa
bidoubiwa approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Base automatically changed from keys-changes to bump-meilisearch-v0.28.0 August 4, 2022 12:55
@brunoocasali brunoocasali merged commit b9435e5 into bump-meilisearch-v0.28.0 Aug 4, 2022
@brunoocasali brunoocasali deleted the indexes-changes branch August 4, 2022 12:56
@brunoocasali brunoocasali added the enhancement New feature or request label Aug 4, 2022
This was referenced Aug 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunoocasali @bidoubiwa