-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addd waitForPending update method #73
Conversation
bors try |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed two things in this review
- As the update routes give information about a process and not a result, I changed ResultType for ProcessType.
- In all other SDK's it is
waitForPendingUpdate
and notwaitForPendingUpdate
so I changed it! :)
Should be merged after #71 |
@ppamorim, there are conflicts, sorry but we cannot use Bors here for the moment 😕 You need to rebase your branch. |
f8bc033
to
2ecf83f
Compare
752f88a
to
7137a7d
Compare
bors try |
tryBuild succeeded: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! Thanks!
bors merge |
@ppamorim is this PR breakable because you change |
Build succeeded: |
@curquiza This is a required change because the update result may not return the number field. Before this the test was crashing. |
This PR removes the usage of
Thread.sleep(timeInterval:)
included between async calls. I tried to implement a solution based onDispatchSemaphore
but this turns out to be problematic when used inside closures and it was creating a deadlock.