Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corrupted data during placeholder search #1089

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix corrupted data during placeholder search #1089

merged 2 commits into from
Nov 20, 2020

Conversation

MarinPostma
Copy link
Contributor

close #1088

The placeholder data was not cleared on when deleting all documents.

@MarinPostma MarinPostma added this to the 12/2020 milestone Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #1089 (f2fe969) into master (ef6b56d) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1089      +/-   ##
==========================================
+ Coverage   76.53%   76.94%   +0.40%     
==========================================
  Files         104      104              
  Lines       12127    12146      +19     
==========================================
+ Hits         9282     9346      +64     
+ Misses       2845     2800      -45     
Impacted Files Coverage Δ
meilisearch-core/src/update/clear_all.rs 95.65% <100.00%> (+95.65%) ⬆️
meilisearch-http/tests/documents_delete.rs 100.00% <100.00%> (ø)
meilisearch-core/src/bucket_sort.rs 81.34% <0.00%> (-0.06%) ⬇️
meilisearch-core/src/number.rs 31.78% <0.00%> (ø)
meilisearch-http/tests/common.rs 91.13% <0.00%> (+0.28%) ⬆️
meilisearch-core/src/store/mod.rs 66.24% <0.00%> (+1.27%) ⬆️
meilisearch-core/src/update/mod.rs 77.11% <0.00%> (+4.97%) ⬆️
meilisearch-http/src/routes/document.rs 99.35% <0.00%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a67862...0645a65. Read the comment docs.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 20, 2020

Build succeeded:

@bors bors bot merged commit fe3e207 into master Nov 20, 2020
@bors bors bot deleted the fix-clear-bug branch November 20, 2020 09:49
@MarinPostma MarinPostma removed the RFR label Nov 30, 2020
@ManyTheFish ManyTheFish changed the title Fix clear bug Fix corrupted data during placeholder search Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted data during search (POST)
2 participants