Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the experimental drop search after and nb search per core #5000

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Implement the experimental drop search after and nb search per core #5000

merged 5 commits into from
Oct 10, 2024

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

Fixes #4997
Fixes #4995

What does this PR do?

  • Add an experimental parameter to decide how many searches can be processed per core
  • Add an experimental parameter to configure after how many seconds a search should be dropped

@irevoire irevoire added performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption experimental feature Related to an experimental feature rust Pull requests that update Rust code labels Oct 10, 2024
@irevoire irevoire added this to the v1.10.3 milestone Oct 10, 2024
@irevoire irevoire requested a review from a team October 10, 2024 11:23
dureuill
dureuill reviewed Oct 10, 2024
View reviewed changes
meilisearch/src/option.rs Outdated Show resolved Hide resolved
dureuill
dureuill reviewed Oct 10, 2024
View reviewed changes
meilisearch/src/option.rs Outdated Show resolved Hide resolved
irevoire and others added 2 commits October 10, 2024 13:40
@irevoire @dureuill
Update meilisearch/src/option.rs
6c017bd 
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@irevoire @dureuill
Update meilisearch/src/option.rs
76c6027 
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
This was linked to issues Oct 10, 2024
Let the user configures how many searches can be processed by cores #4997
Closed
Let users configure the time after which meilisearch drops the search requests #4995
Closed
Kerollmops
Kerollmops requested changes Oct 10, 2024
View reviewed changes
meilisearch/src/option.rs Outdated Show resolved Hide resolved
@irevoire @Kerollmops
Update meilisearch/src/option.rs
f47a23b 
Co-authored-by: Clément Renault <clement@meilisearch.com>
Kerollmops
Kerollmops approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors bot merged commit cf5aa63 into release-v1.10.3 Oct 10, 2024
10 checks passed
@meili-bors meili-bors bot deleted the experimental-search-features branch October 10, 2024 14:00
This was referenced Oct 14, 2024
Closed
Closed
@irevoire irevoire mentioned this pull request Oct 14, 2024
Merged
meili-bors bot added a commit that referenced this pull request Oct 14, 2024
@meili-bors @irevoire
Merge #5006
a0b3887 
5006: Bring back changes from v1.10.3 r=Kerollmops a=irevoire

# Pull Request

## Related issue
Port the following PR to the latest version: #5000
See its description for more information

Co-authored-by: Tamo <tamo@meilisearch.com>
@meili-bot meili-bot added the v1.10.3 PRs/issues solved in v1.10.3 label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

@dureuill dureuill Awaiting requested review from dureuill

Assignees
No one assigned
Labels
experimental feature Related to an experimental feature performance Related to the performance in term of search/indexation speed or RAM/CPU/Disk consumption rust Pull requests that update Rust code v1.10.3 PRs/issues solved in v1.10.3
Projects
None yet
Milestone
v1.10.3
4 participants
@irevoire @Kerollmops @dureuill @meili-bot