-
Notifications
You must be signed in to change notification settings - Fork 82
exporting heed to avoid having different versions of Heed in Meilisearch #464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, merging!
bors merge
464: exporting heed to avoid having different versions of Heed in Meilisearch r=Kerollmops a=psvnlsaikumar # Pull Request ## What does this PR do? Fixes the issue in meilisearch meilisearch/meilisearch#2210 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
Build failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, could you do a rustfmt pass, please?
cargo +nightly fmt
@Kerollmops Performed cargo +nightly fmt . I hope that this was the expectation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, thank you!
bors merge
464: exporting heed to avoid having different versions of Heed in Meilisearch r=Kerollmops a=psvnlsaikumar # Pull Request ## What does this PR do? Fixes the issue in meilisearch meilisearch/meilisearch#2210 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
Timed out. |
bors merge |
464: exporting heed to avoid having different versions of Heed in Meilisearch r=curquiza a=psvnlsaikumar # Pull Request ## What does this PR do? Fixes the issue in meilisearch meilisearch/meilisearch#2210 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
Timed out. |
bors merge |
This PR is breaking as, even if it is the same version as before, cargo/rustc is not smart enough to understand that and makes calling crates break. |
Pull Request
What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!