Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add a "Criterion implementation strategy" parameter to Search #742

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

loiclec
Copy link
Contributor

@loiclec loiclec commented Dec 14, 2022

Add a parameter to search requests which determines the implementation strategy of the criteria. This can be either set-based, iterative, or dynamic (ie choosing between set-based or iterative at search time). See meilisearch/meilisearch#3356 for more context about this change.

@loiclec loiclec force-pushed the criterion-implementation-strategy branch from e2e4aee to 2df908e Compare December 21, 2022 08:32
@loiclec loiclec added benchmarks Related to the benchmarks no breaking The related changes are not breaking (DB nor API) maintenance Issue about maintenance (CI, tests, refacto...) labels Dec 21, 2022
@loiclec loiclec marked this pull request as ready for review December 21, 2022 10:39
@loiclec loiclec requested a review from irevoire December 21, 2022 10:50
@loiclec loiclec force-pushed the criterion-implementation-strategy branch from a83f8ba to 339a4b0 Compare December 21, 2022 11:49
@loiclec loiclec changed the title Add a "Criterion implementation strategy" parameter to Search and improve the search benchmarks Add a "Criterion implementation strategy" parameter to Search Dec 21, 2022
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you
bors merge

@bors
Copy link
Contributor

bors bot commented Dec 21, 2022

@bors bors bot merged commit a8defb5 into main Dec 21, 2022
@bors bors bot deleted the criterion-implementation-strategy branch December 21, 2022 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
benchmarks Related to the benchmarks maintenance Issue about maintenance (CI, tests, refacto...) no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants